Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 unarchiving_utils are now based on 7zip cli #6959

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
97fd911
move archive to port instead of failing
Dec 12, 2024
29533e9
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 12, 2024
ca87d0b
using log context and rename
Dec 13, 2024
7f3e41e
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 13, 2024
be58b0c
refactor to use less generic error UnsupportedArchiveFormat
Dec 13, 2024
53e0728
renaming error
Dec 13, 2024
65b5291
replace unarchiver
Dec 16, 2024
e6d118d
remove unused
Dec 16, 2024
2a2f917
remove comment
Dec 16, 2024
56d7fe1
refactor 7zip
Dec 16, 2024
9c82bc5
fixed broken install
Dec 16, 2024
5a4cfb5
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 16, 2024
0f315e0
refactor
Dec 16, 2024
7ede41a
mypy
Dec 16, 2024
9d67dd1
added extra test
Dec 16, 2024
0f1642d
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 17, 2024
71adc5b
move to folder
Dec 17, 2024
01ce053
small enhancements in tests
Dec 17, 2024
79c1648
restructure package
Dec 17, 2024
02c9497
modules renaming
Dec 17, 2024
c01e35a
refactor
Dec 17, 2024
13c1485
fix refactor
Dec 17, 2024
653e168
added decompress progress
Dec 17, 2024
6dfcd95
fixed issues with parsing progress
Dec 17, 2024
c3b0c1c
restructure tests with common utils
Dec 19, 2024
56d1871
added notes to deprecate
Dec 19, 2024
30346af
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 19, 2024
a9145e2
remove unwanted code
Dec 19, 2024
46a0c29
remove unused
Dec 19, 2024
c04999c
removed unused feature
Dec 19, 2024
d48de81
refactor to drop relative_paths since it's always True
Dec 19, 2024
9ff2374
added tqdm progress
Dec 19, 2024
0364e8b
refactor common code
Dec 19, 2024
7205c2f
connected progressbar
Dec 19, 2024
79cc7e8
added dropin interface
Dec 19, 2024
e69bc9a
remove old unused interface
Dec 19, 2024
e282c95
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 19, 2024
7279155
removes unused repro-zipfile
Dec 19, 2024
571a411
refactor imports
Dec 19, 2024
da30d13
restructure model
Dec 19, 2024
9ca1090
simplify outputs parsing
Dec 19, 2024
97bdff1
install path is now fixed to avoid using old system versions
Dec 20, 2024
280b0d3
fixed 7z installation
Dec 20, 2024
6759dc7
enhanced 7zip interface
Dec 20, 2024
4a5a3a6
added arm64 target install
Dec 20, 2024
21c7f0a
fixed lines scanning parsing
Dec 20, 2024
a58849f
added edge case test
Dec 20, 2024
f5ae500
Merge remote-tracking branch 'upstream/master' into pr-osparc-deflate…
Dec 20, 2024
abc45ef
refactor
Dec 20, 2024
82413f1
refactor
Dec 20, 2024
cbf7533
rename
Dec 20, 2024
5739963
mypy
Dec 20, 2024
9495ac1
making flatter
Dec 20, 2024
d693eeb
revert change
Dec 20, 2024
7e5b967
adding missing
Dec 20, 2024
05ab2f1
remove unused
Dec 20, 2024
7041eee
remove useless
Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused
  • Loading branch information
Andrei Neagu committed Dec 16, 2024
commit e6d118d542ea54fde2fdf313ddd6fc521c1b43c5
8 changes: 0 additions & 8 deletions packages/service-library/src/servicelib/archiving_utils.py
Original file line number Diff line number Diff line change
@@ -35,10 +35,6 @@ class ArchiveError(Exception):
"""


class UnsupportedArchiveFormatError(Exception):
pass


def _human_readable_size(size, decimal_places=3):
human_readable_file_size = float(size)
unit = "B"
@@ -264,10 +260,6 @@ async def unarchive_dir(
f"Failed unarchiving {archive_to_extract} -> {destination_folder} due to {type(err)}."
f"Details: {err}"
)
# maybe write unsupported error format here instead of all this to be able to still raise in case of error
if isinstance(err, NotImplementedError):
raise UnsupportedArchiveFormatError(msg) from err

raise ArchiveError(msg) from err

# NOTE: extracted_paths includes all tree leafs, which might include files and empty folders
Loading