Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix issue with sending metrics that are None to Prometheus #6951

Merged

Merge branch 'master' into pr-osparc-fix-metric-raising-errors

5fc3ae0
Select commit
Loading
Failed to load commit list.
Merged

🐛 Fix issue with sending metrics that are None to Prometheus #6951

Merge branch 'master' into pr-osparc-fix-metric-raising-errors
5fc3ae0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

67.86% (-20.22%) compared to c0df260

View this Pull Request on Codecov

67.86% (-20.22%) compared to c0df260

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (c0df260) to head (5fc3ae0).

❗ There is a different number of reports uploaded between BASE (c0df260) and HEAD (5fc3ae0). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (c0df260) HEAD (5fc3ae0)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6951       +/-   ##
===========================================
- Coverage   88.08%   67.86%   -20.22%     
===========================================
  Files        1589      632      -957     
  Lines       62243    30616    -31627     
  Branches     2012      262     -1750     
===========================================
- Hits        54825    20779    -34046     
- Misses       7082     9777     +2695     
+ Partials      336       60      -276     
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.38% <100.00%> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.61% <ø> (-28.14%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0df260...5fc3ae0. Read the comment docs.