-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fix opentelemetry detach bug #6941
🐛Fix opentelemetry detach bug #6941
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6941 +/- ##
==========================================
+ Coverage 88.04% 88.16% +0.12%
==========================================
Files 1590 1232 -358
Lines 62304 52556 -9748
Branches 2008 993 -1015
==========================================
- Hits 54854 46337 -8517
+ Misses 7115 6026 -1089
+ Partials 335 193 -142
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Quality Gate passedIssues Measures |
What do these changes do?
opentelemetry.context.detach
object
which is too general. IMO that should beTypeAlias
d in the opentelemetry repo. Then I bet mypy could have detected the issue. Maybe I create a fix on their side as well.Related issue/s
How to test
Dev-ops checklist