Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix opentelemetry detach bug #6941

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Dec 11, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.16%. Comparing base (92ddd6c) to head (083878a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6941      +/-   ##
==========================================
+ Coverage   88.04%   88.16%   +0.12%     
==========================================
  Files        1590     1232     -358     
  Lines       62304    52556    -9748     
  Branches     2008      993    -1015     
==========================================
- Hits        54854    46337    -8517     
+ Misses       7115     6026    -1089     
+ Partials      335      193     -142     
Flag Coverage Δ
integrationtests 64.95% <ø> (-0.01%) ⬇️
unittests 86.04% <25.00%> (-0.23%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 75.10% <25.00%> (-0.04%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.37% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.99% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.65% <ø> (ø)
resource_usage_tracker 89.58% <ø> (ø)
storage 89.60% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 87.70% <ø> (+0.23%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ddd6c...083878a. Read the comment docs.

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@bisgaard-itis bisgaard-itis merged commit 791d9d1 into ITISFoundation:master Dec 11, 2024
99 of 103 checks passed
@bisgaard-itis bisgaard-itis deleted the 6938-fix-opentelemetry-detach-error branch December 11, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open telemetry exception raised because of type error
4 participants