🐛 Fix deletion of files in folders

[giancarloromeo]

What do these changes do?

Fix deletion of untracked files (without an entry in file_meta_data table).

In the previous implementation, a suppressed exception caused the issue.
The first enclosing file (directory) in the table is updated accordingly (i.e. invalidating size) after the physical deletion.

Related issue/s

• Resolves: Cannot delete a file osparc-issues#1788

How to test

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.37%. Comparing base (e97f83b) to head (a71c718).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e97f83b) and HEAD (a71c718). Click for more details.

HEAD has 29 uploads less than BASE

Flag	BASE (e97f83b)	HEAD (a71c718)
unittests	30	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #6935       +/-   ##
===========================================
- Coverage   88.09%   66.37%   -21.73%     
===========================================
  Files        1592      669      -923     
  Lines       62319    32423    -29896     
  Branches     2012      262     -1750     
===========================================
- Hits        54903    21521    -33382     
- Misses       7080    10842     +3762     
+ Partials      336       60      -276     

Flag	Coverage Δ
integrationtests	64.97% <ø> (-0.02%)	⬇️
unittests	66.86% <86.66%> (-19.47%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.37% <ø> (-8.02%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	78.83% <ø> (-12.57%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	59.86% <ø> (-29.89%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
osparc_gateway_server	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	89.54% <86.66%> (-0.08%)	⬇️
webclient	∅ <ø> (∅)
webserver	59.61% <ø> (-28.14%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e97f83b...a71c718. Read the comment docs.

[odeimaiz]

👍

[sanderegg]

Please see my comments, I think there are some issues. Thanks a lot!

[sanderegg]

Thanks a bunch, I added a few more suggestions.

[pcrespov]

please ask again for a review when new changes are in

same here

[pcrespov]

same here

[sanderegg]

Thanks a lot!

[GitHK]

Thanks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud