Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor github workflow file #6926

Merged

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Dec 9, 2024

What do these changes do?

  • refactor github workflow file
  • add a new github workflow which is required to run when merging into master (i.e. it is only run on PRs)

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.29%. Comparing base (e9bc718) to head (c9be60f).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e9bc718) and HEAD (c9be60f). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (e9bc718) HEAD (c9be60f)
unittests 30 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6926       +/-   ##
===========================================
- Coverage   88.23%   66.29%   -21.94%     
===========================================
  Files        1571      672      -899     
  Lines       61649    31996    -29653     
  Branches     2000      262     -1738     
===========================================
- Hits        54393    21212    -33181     
- Misses       6920    10724     +3804     
+ Partials      336       60      -276     
Flag Coverage Δ *Carryforward flag
integrationtests 65.05% <ø> (+1.10%) ⬆️ Carriedforward from ed17770
unittests 90.57% <ø> (+4.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.37% <ø> (-8.02%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.78% <ø> (-12.61%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.65% <ø> (-28.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9bc718...c9be60f. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. can we apply more of this magic and reduce further the verbose content of ci-testing-deploy.yml?

@bisgaard-itis
Copy link
Contributor Author

nice. can we apply more of this magic and reduce further the verbose content of ci-testing-deploy.yml?

We could probably reuse some workflows. However, I will not do that here as the workflow file I introduce here will only run on PRs (differently from the other workflow file)

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) December 10, 2024 06:56
@bisgaard-itis bisgaard-itis merged commit 6d1ee29 into ITISFoundation:master Dec 10, 2024
88 of 92 checks passed
@bisgaard-itis bisgaard-itis deleted the refactor-gh-workflow-file branch December 10, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants