Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️CI: Separate image building of frontend #6918

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Dec 6, 2024

What do these changes do?

Building the frontend docker image seems to become more and more resource intensive on the github runners, especially when USA wakes up.

This PR:

  • separates in 2 separate jobs building of the backend and the frontend,
  • both upload now to an CI artifact named docker-buildx-images-${{ runner.os }}-${{ github.sha }}-backend and docker-buildx-images-${{ runner.os }}-${{ github.sha }}-frontend ,
  • integration tests that only need the backend depend only on the backend images being built
  • system tests need both the backend and frontend now have that additional dependency
  • improved load images step by parallelizing (gain of ~50%, ~1m20 to 30-40s),
  • some small changes in dockerfile caching that might bring some help
  • removed step to delete data that takes 1minute for deletion

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work labels Dec 6, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Dec 6, 2024
@sanderegg sanderegg self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (186c07b) to head (f4c2e35).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6918      +/-   ##
==========================================
+ Coverage   88.35%   89.31%   +0.96%     
==========================================
  Files        1571     1112     -459     
  Lines       61614    48408   -13206     
  Branches     1999      403    -1596     
==========================================
- Hits        54437    43237   -11200     
+ Misses       6841     5091    -1750     
+ Partials      336       80     -256     
Flag Coverage Δ
integrationtests 65.05% <ø> (-0.13%) ⬇️
unittests 87.02% <ø> (+0.49%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.49% <ø> (+0.08%) ⬆️
director_v2 91.38% <ø> (-0.05%) ⬇️
dynamic_scheduler 97.07% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.65% <ø> (ø)
resource_usage_tracker 89.07% <ø> (+0.29%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.37% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 186c07b...f4c2e35. Read the comment docs.

@sanderegg sanderegg marked this pull request as ready for review December 8, 2024 21:42
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. So front-end and backend images are now created separately.
Thx

@sanderegg sanderegg enabled auto-merge (squash) December 8, 2024 21:54
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg force-pushed the separate-build-step-frontend branch from 6bacabe to f4c2e35 Compare December 9, 2024 07:57
Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciated 👏

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot. 👍🏻

.github/workflows/ci-testing-deploy.yml Show resolved Hide resolved
@sanderegg sanderegg disabled auto-merge December 9, 2024 08:41
@sanderegg sanderegg merged commit 66a4217 into ITISFoundation:master Dec 9, 2024
91 of 92 checks passed
@sanderegg sanderegg deleted the separate-build-step-frontend branch December 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants