-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️CI: Separate image building of frontend #6918
⚗️CI: Separate image building of frontend #6918
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6918 +/- ##
==========================================
+ Coverage 88.35% 89.31% +0.96%
==========================================
Files 1571 1112 -459
Lines 61614 48408 -13206
Branches 1999 403 -1596
==========================================
- Hits 54437 43237 -11200
+ Misses 6841 5091 -1750
+ Partials 336 80 -256
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. So front-end and backend images are now created separately.
Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
6bacabe
to
f4c2e35
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciated 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks a lot. 👍🏻
What do these changes do?
Building the frontend docker image seems to become more and more resource intensive on the github runners, especially when USA wakes up.
This PR:
docker-buildx-images-${{ runner.os }}-${{ github.sha }}-backend
anddocker-buildx-images-${{ runner.os }}-${{ github.sha }}-frontend
,load images
step by parallelizing (gain of ~50%, ~1m20 to 30-40s),Related issue/s
How to test
Dev-ops checklist