Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Redirecting inputs retrieval via dynamic-scheduler ⚠️ #6908

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 5, 2024

⚠️ devops

  • dynamic-scheduler also uses existing DYNAMIC_SIDECAR_API_SAVE_RESTORE_STATE_TIMEOUT
  • no action required

What do these changes do?

Inputs retrieval is now redirected via dynamic-scheduler.

Bonus:

  • unified retrieve calls in webserver

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 5, 2024
@GitHK GitHK added a:webserver issue related to the webserver service a:dynamic-scheduler labels Dec 5, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (75aed81) to head (d72d8c9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6908      +/-   ##
==========================================
+ Coverage   87.06%   87.68%   +0.62%     
==========================================
  Files        1611     1586      -25     
  Lines       63598    62313    -1285     
  Branches     2025     2026       +1     
==========================================
- Hits        55370    54641     -729     
+ Misses       7894     7338     -556     
  Partials      334      334              
Flag Coverage Δ
integrationtests 64.91% <50.00%> (+0.98%) ⬆️
unittests 85.94% <70.21%> (+0.59%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.36% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.26% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.20% <0.00%> (-0.09%) ⬇️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.57% <50.00%> (+0.17%) ⬆️
director_v2 91.41% <ø> (+0.01%) ⬆️
dynamic_scheduler 97.10% <100.00%> (+0.06%) ⬆️
dynamic_sidecar 89.72% <ø> (-0.04%) ⬇️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.58% <ø> (ø)
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.19% <50.00%> (+1.82%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75aed81...d72d8c9. Read the comment docs.

@GitHK GitHK marked this pull request as ready for review December 11, 2024 09:26
@YuryHrytsuk
Copy link
Contributor

There is a new ENV.

Shall we expect the releated PR in config repo?

@GitHK GitHK changed the title ♻️ Redirecting inputs retrieval via dynamic-scheduler ♻️ Redirecting inputs retrieval via dynamic-scheduler ⚠️ Dec 11, 2024
@GitHK
Copy link
Contributor Author

GitHK commented Dec 11, 2024

There is a new ENV.

Shall we expect the releated PR in config repo?

@YuryHrytsuk just updated the description. it's and existing env. I expect no changes.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. But I have the same question as in #6943 (review)

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the explanation.

@GitHK GitHK enabled auto-merge (squash) December 16, 2024 14:55
Andrei Neagu added 2 commits December 17, 2024 09:46
…' of github.com:GitHK/osparc-simcore-forked into pr-osparc-redirect-more-dv2-calls-via-dynamic-scheduler
@sanderegg sanderegg disabled auto-merge December 17, 2024 10:57
@sanderegg sanderegg merged commit acd677a into ITISFoundation:master Dec 17, 2024
87 of 91 checks passed
@GitHK GitHK deleted the pr-osparc-redirect-more-dv2-calls-via-dynamic-scheduler branch December 17, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dynamic-scheduler a:webserver issue related to the webserver service
Projects
None yet
5 participants