-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Friendlier logger #6907
🎨 [Frontend] Friendlier logger #6907
Conversation
…mcore into enh/friendlier-logger
Nice. Why not using the same color for the error as in the |
Yes, it's there. I recorded the animation right before realizing the error icon was yellow 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it. When was the last time you were interested in the INFO messages but not in the ERROR messages? Furthermore, I would need to add a new option, SHOW ALL which would be default, and this Show all would behave differently depending on the user's role, because we don't show the Debug messages to non-tester users... An effort which I believe it's not worth. |
I am not suggesting only to have all options available but rather than the UX is confusing. If i select in a filter INFO, i was expecting to filter only the values that are marked as INFO but what the UI does is showing "at least INFO". If that is the case, IMO the UX should change to indicate so. I am not sure how, ... perhaps adding "show at least.. ."? or "min log-level" ... or writing ">=" ?? Not sure
As I mentioned earlier, my comment is more on the UX rather than the availability of options. |
…mcore into enh/friendlier-logger
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
What do these changes do?
requested by @AntoninoMarioC
After:
Before:
Related issue/s
How to test
Dev-ops checklist