Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ exposing dynamic-scheduler interface by default on /dynamic-scheduler/ #6906

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Dec 5, 2024

What do these changes do?

By default to access the dynamic-scheduler's interface you have to go http://HOST:PORT/dynamic-scheduler/

This allows OPS to properly expose the dashboard via monitoring.DOMANE.com/dynamic-scheduler/

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Dec 5, 2024
@GitHK GitHK added this to the Event Horizon milestone Dec 5, 2024
@GitHK GitHK changed the title ♻️ exposing dynamic-scheduler interface by default on ´/dynamic-scheduler` ♻️ exposing dynamic-scheduler interface by default on ´/dynamic-scheduler/` Dec 5, 2024
@GitHK GitHK marked this pull request as ready for review December 5, 2024 08:51
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.82%. Comparing base (3960405) to head (e7617bf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6906      +/-   ##
==========================================
+ Coverage   87.80%   87.82%   +0.01%     
==========================================
  Files        1586     1579       -7     
  Lines       62417    62242     -175     
  Branches     2005     2005              
==========================================
- Hits        54804    54661     -143     
+ Misses       7277     7246      -31     
+ Partials      336      335       -1     
Flag Coverage Δ
integrationtests 64.74% <ø> (-3.16%) ⬇️
unittests 86.03% <89.47%> (-0.09%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.07% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.05% <ø> (ø)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 75.60% <ø> (+0.09%) ⬆️
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.04% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.37% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.99% <89.47%> (-0.16%) ⬇️
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.65% <ø> (ø)
resource_usage_tracker 89.24% <ø> (+0.29%) ⬆️
storage 89.60% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.59% <ø> (-0.10%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3960405...e7617bf. Read the comment docs.

Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Feel free to merge it.

Once it is deployed, I will test new Traefik settings and add these settings to the code

@GitHK GitHK changed the title ♻️ exposing dynamic-scheduler interface by default on ´/dynamic-scheduler/` ♻️ exposing dynamic-scheduler interface by default on /dynamic-scheduler/ Dec 5, 2024
@GitHK
Copy link
Contributor Author

GitHK commented Dec 5, 2024

@mrnicegyu11 you can skip this one we already synced with YH on it and we're 'gonna follow it up together.

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as instructed only approved to unblock, didnt read CC

Andrei Neagu added 3 commits December 9, 2024 16:34
…-scheduler-monitoring-dashboard-mount-point
…point' of github.com:GitHK/osparc-simcore-forked into pr-osparc-dynamic-scheduler-monitoring-dashboard-mount-point
@GitHK GitHK enabled auto-merge (squash) December 9, 2024 15:36
@GitHK GitHK disabled auto-merge December 11, 2024 08:28
@GitHK GitHK enabled auto-merge (squash) December 11, 2024 08:29
@pcrespov pcrespov disabled auto-merge December 11, 2024 09:20
@pcrespov pcrespov merged commit a35576c into ITISFoundation:master Dec 11, 2024
89 of 93 checks passed
@GitHK GitHK deleted the pr-osparc-dynamic-scheduler-monitoring-dashboard-mount-point branch December 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants