-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ exposing dynamic-scheduler
interface by default on /dynamic-scheduler/
#6906
♻️ exposing dynamic-scheduler
interface by default on /dynamic-scheduler/
#6906
Conversation
…-scheduler-monitoring-dashboard-mount-point
…-scheduler-monitoring-dashboard-mount-point
dynamic-scheduler
interface by default on ´/dynamic-scheduler`dynamic-scheduler
interface by default on ´/dynamic-scheduler/`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6906 +/- ##
==========================================
+ Coverage 87.80% 87.82% +0.01%
==========================================
Files 1586 1579 -7
Lines 62417 62242 -175
Branches 2005 2005
==========================================
- Hits 54804 54661 -143
+ Misses 7277 7246 -31
+ Partials 336 335 -1
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Feel free to merge it.
Once it is deployed, I will test new Traefik settings and add these settings to the code
dynamic-scheduler
interface by default on ´/dynamic-scheduler/`dynamic-scheduler
interface by default on /dynamic-scheduler/
@mrnicegyu11 you can skip this one we already synced with YH on it and we're 'gonna follow it up together. |
…hboard-mount-point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as instructed only approved to unblock, didnt read CC
...ices/dynamic-scheduler/src/simcore_service_dynamic_scheduler/api/frontend/routes/_service.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/api/frontend/routes/_index.py
Show resolved
Hide resolved
services/dynamic-scheduler/src/simcore_service_dynamic_scheduler/core/settings.py
Show resolved
Hide resolved
…-scheduler-monitoring-dashboard-mount-point
…point' of github.com:GitHK/osparc-simcore-forked into pr-osparc-dynamic-scheduler-monitoring-dashboard-mount-point
…hboard-mount-point
Quality Gate passedIssues Measures |
What do these changes do?
By default to access the dynamic-scheduler's interface you have to go
http://HOST:PORT/dynamic-scheduler/
This allows OPS to properly expose the dashboard via
monitoring.DOMANE.com/dynamic-scheduler/
Related issue/s
How to test
Dev-ops checklist