Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Multiselect data #6896

Merged
merged 35 commits into from
Dec 12, 2024
Merged

🎨 [Frontend] Multiselect data #6896

merged 35 commits into from
Dec 12, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Dec 3, 2024 •
edited
Loading

What do these changes do?

  • Allow multiselection and support call multi-delete and multi-downloadFile
  • Refactor Data Management widgets

MultiSelect

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Dec 3, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Dec 3, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Dec 3, 2024
odeimaiz and others added 25 commits December 3, 2024 15:08
@odeimaiz odeimaiz marked this pull request as ready for review December 12, 2024 08:58
matusdrobuliak66
matusdrobuliak66 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz enabled auto-merge (squash) December 12, 2024 09:10
pcrespov
pcrespov reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz disabled auto-merge December 12, 2024 10:25
@odeimaiz odeimaiz enabled auto-merge (squash) December 12, 2024 10:32
ignapas
ignapas approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not CTRL or SHIFT for multi-selection?

@odeimaiz
Copy link
Member Author

why not CTRL or SHIFT for multi-selection?

Yep, I could also support Ctrl and Shift, but the button is required.

sanderegg
sanderegg reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@odeimaiz odeimaiz disabled auto-merge December 12, 2024 14:02
@odeimaiz odeimaiz merged commit ed110f4 into ITISFoundation:master Dec 12, 2024
55 checks passed
@odeimaiz odeimaiz deleted the enh/multiselect-data branch December 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Support multiDownload and multiDelete
6 participants
@odeimaiz @ignapas @GitHK @pcrespov @sanderegg @matusdrobuliak66