-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Making dy-sidecar start faster when volumes contain data #6886
🐛 Making dy-sidecar start faster when volumes contain data #6886
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6886 +/- ##
==========================================
+ Coverage 88.31% 89.75% +1.43%
==========================================
Files 1553 73 -1480
Lines 61193 3172 -58021
Branches 2095 0 -2095
==========================================
- Hits 54043 2847 -51196
+ Misses 6818 325 -6493
+ Partials 332 0 -332
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's more than 3 right? and all the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Quality Gate passedIssues Measures |
What do these changes do?
Bumped
dynamic-sidecar
's health check'sstart-period
to 180 seconds.Removed
--verbose
flags which reduced by ~3 orders of magnitude the speed of chmod and chown commands.Related issue/s
How to test
Dev-ops checklist