-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] listen to iframe messages PoC #6884
Merged
odeimaiz
merged 10 commits into
ITISFoundation:master
from
odeimaiz:feature/listen-to-iframe-messages
Dec 4, 2024
Merged
✨ [Frontend] listen to iframe messages PoC #6884
odeimaiz
merged 10 commits into
ITISFoundation:master
from
odeimaiz:feature/listen-to-iframe-messages
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Improvement or request on an existing feature
a:frontend
issue affecting the front-end (area group)
labels
Dec 2, 2024
odeimaiz
changed the title
✨ [Frontend] listen to iframe messages POC
✨ [Frontend] listen to iframe messages PoC
Dec 4, 2024
odeimaiz
requested review from
mguidon,
giancarloromeo,
GitHK,
pcrespov,
sanderegg and
matusdrobuliak66
December 4, 2024 09:52
matusdrobuliak66
approved these changes
Dec 4, 2024
jsaq007
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
pcrespov
approved these changes
Dec 4, 2024
sanderegg
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Quality Gate passedIssues Measures |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a:frontend
issue affecting the front-end (area group)
t:enhancement
Improvement or request on an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In order to open the ViP Market window when the Rocket asks for it, we need to listen to the messages coming from the iframes.
This Proof of Concept will listen to the theme changes, if this works, the functionality will be extended and standardized.
Related issue/s
How to test
Dev-ops checklist