Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Remove deprecated from_orm method (Pydantic v2) #6869

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 29, 2024

What do these changes do?

Removes the use of from_orm method in favor of model_validate.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 29, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 29, 2024 14:27
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (3dded08) to head (864de2b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6869      +/-   ##
==========================================
+ Coverage   88.37%   88.40%   +0.02%     
==========================================
  Files        1553     1546       -7     
  Lines       61866    61676     -190     
  Branches     2110     2110              
==========================================
- Hits        54675    54524     -151     
+ Misses       6860     6821      -39     
  Partials      331      331              
Flag Coverage Δ
integrationtests 64.73% <ø> (-0.01%) ⬇️
unittests 86.31% <91.66%> (+<0.01%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.28% <ø> (ø)
pkg_dask_task_models_library 96.57% <ø> (ø)
pkg_models_library 91.22% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.52% <100.00%> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 75.91% <ø> (ø)
pkg_settings_library 90.62% <ø> (ø)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <80.00%> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.02% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (+0.03%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.64% <ø> (-0.15%) ⬇️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.66% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dded08...864de2b. Read the comment docs.

@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Nov 29, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 29, 2024
@giancarloromeo giancarloromeo requested a review from GitHK November 29, 2024 14:28
@giancarloromeo giancarloromeo changed the title ♻️ Remove deprecated from_orm Pydantic v2 method ♻️ Remove deprecated from_orm method (Pydantic v2) Nov 29, 2024
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 29, 2024 14:50
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Copy link

sonarqubecloud bot commented Dec 2, 2024

@giancarloromeo giancarloromeo merged commit 994c575 into ITISFoundation:master Dec 2, 2024
88 of 90 checks passed
@giancarloromeo giancarloromeo deleted the remove-deprecated-from-orm branch December 17, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants