-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance: removing/adding EFS env vars ⚠️ #6837
♻️ Maintenance: removing/adding EFS env vars ⚠️ #6837
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6837 +/- ##
==========================================
+ Coverage 88.38% 88.41% +0.02%
==========================================
Files 1561 1554 -7
Lines 62396 62209 -187
Branches 2108 2164 +56
==========================================
- Hits 55151 54999 -152
+ Misses 6914 6880 -34
+ Partials 331 330 -1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget corresponding MRs
Q: Why we should merge config PR after this MR is in PROD and not before? This is usually the other way around |
Because it is a breaking change if we merge it now. This is the easiest way how to get rid of those vars and do not break anything. |
Quality Gate passedIssues Measures |
dfd1463
into
ITISFoundation:master
What do these changes do?
EFS_ONLY_ENABLED_FOR_USERIDS
which is not used anymoreEFS_DEFAULT_USER_SERVICE_SIZE_BYTES
to the docker-compose (that was manually added in the production deployment)Related issue/s
How to test
Dev-ops checklist