Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Pydantic V2: interpretation of "None" changed #6820

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 25, 2024

What do these changes do?

Pydantic V1 version of EC2 settings was interpreting the string None as python None. This changed with the new version of the ec2 settings.py
This PR ensures the string null is set in case it is python None.

Due to this issue, the autoscaling service running in the private clusters is disabled.

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.61%. Comparing base (3fe2e6f) to head (f2ddc8e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3fe2e6f) and HEAD (f2ddc8e). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (3fe2e6f) HEAD (f2ddc8e)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6820       +/-   ##
===========================================
- Coverage   88.38%   65.61%   -22.78%     
===========================================
  Files        1550      644      -906     
  Lines       61742    31710    -30032     
  Branches     2164      318     -1846     
===========================================
- Hits        54570    20806    -33764     
- Misses       6843    10844     +4001     
+ Partials      329       60      -269     
Flag Coverage Δ *Carryforward flag
integrationtests 64.76% <ø> (ø) Carriedforward from 3fe2e6f
unittests 98.73% <ø> (+12.43%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.54% <ø> (-14.48%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.86% <ø> (-29.89%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.56% <ø> (-29.11%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe2e6f...f2ddc8e. Read the comment docs.

---- 🚨 Try these New Features:

@sanderegg sanderegg force-pushed the pydantic-v2/fix-clusters-keeper-passing-of-endpoint branch from 8fb9212 to f2ddc8e Compare November 25, 2024 09:44
@sanderegg sanderegg merged commit 9df9be7 into ITISFoundation:master Nov 25, 2024
37 of 38 checks passed
@sanderegg sanderegg deleted the pydantic-v2/fix-clusters-keeper-passing-of-endpoint branch November 25, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant