Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨🔨 Improve workflow for performance tests #6815

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Nov 22, 2024

What do these changes do?

  • Improve workflow for performance test. This includes
    • Ensure all settings for a test can be validated in a single command make config input="<all my inputs>".
    • Automatically open localhost:3000 when running make dashboard-up (at least on linux)
  • 🚨 This will probably break the web responsitivity tests. So I will have to fix those after this PR goes in

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Nov 22, 2024
@bisgaard-itis bisgaard-itis added this to the Event Horizon milestone Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (0aeae77) to head (e9ec48c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6815   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files        1550     1550           
  Lines       61750    61750           
  Branches     2164     2164           
=======================================
  Hits        54585    54585           
  Misses       6836     6836           
  Partials      329      329           
Flag Coverage Δ *Carryforward flag
integrationtests 64.76% <ø> (ø)
unittests 86.30% <ø> (ø) Carriedforward from 0aeae77

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 78.42% <ø> (ø)
pkg_aws_library 93.28% <ø> (ø)
pkg_dask_task_models_library 96.57% <ø> (ø)
pkg_models_library 91.17% <ø> (ø)
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 87.52% <ø> (ø)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.10% <ø> (ø)
pkg_settings_library 90.62% <ø> (ø)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.12% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aeae77...e9ec48c. Read the comment docs.

---- 🚨 Try these New Features:

@bisgaard-itis bisgaard-itis changed the title 🎨 Improve workflow for performance tests 🎨🔨 Improve workflow for performance tests Nov 25, 2024
@bisgaard-itis bisgaard-itis marked this pull request as ready for review November 25, 2024 06:55
tests/performance/locust_settings.py Show resolved Hide resolved
tests/performance/locust_settings.py Show resolved Hide resolved
tests/performance/README.md Outdated Show resolved Hide resolved
@bisgaard-itis bisgaard-itis enabled auto-merge (squash) November 25, 2024 10:19
@bisgaard-itis bisgaard-itis merged commit 74c3690 into ITISFoundation:master Nov 25, 2024
89 of 90 checks passed
@bisgaard-itis bisgaard-itis deleted the performance-test-improvements branch November 25, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants