Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use list instead of set when building the expected result #6796

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 21, 2024

What do these changes do?

Use list instead of set so the expected JSON representation has a correct order of items.

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo marked this pull request as ready for review November 21, 2024 14:52
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 21, 2024 14:53
@giancarloromeo giancarloromeo self-assigned this Nov 21, 2024
@giancarloromeo giancarloromeo added the a:director-v2 issue related with the director-v2 service label Nov 21, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.22%. Comparing base (5945ea7) to head (c150d1b).

❗ There is a different number of reports uploaded between BASE (5945ea7) and HEAD (c150d1b). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (5945ea7) HEAD (c150d1b)
unittests 29 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6796       +/-   ##
===========================================
- Coverage   89.08%   71.22%   -17.87%     
===========================================
  Files        1414      615      -799     
  Lines       56697    30853    -25844     
  Branches     1441      318     -1123     
===========================================
- Hits        50510    21975    -28535     
- Misses       5987     8818     +2831     
+ Partials      200       60      -140     
Flag Coverage Δ
integrationtests 64.77% <ø> (+11.31%) ⬆️
unittests 84.48% <ø> (-3.09%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.03% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.72% <ø> (-0.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.57% <ø> (-27.98%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5945ea7...c150d1b. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo changed the title Use list instead of set when building the expected result 🐛 Use list instead of set when building the expected result Nov 21, 2024
@giancarloromeo giancarloromeo merged commit b93ccbf into ITISFoundation:master Nov 21, 2024
85 of 90 checks passed
@giancarloromeo giancarloromeo deleted the fix-dy-sidecar-state-exclude branch November 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants