-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [e2e] Study Options: Open button #6775
🐛 [e2e] Study Options: Open button #6775
Conversation
…iz/osparc-simcore into e2e/wait-until-title-is-filled-up
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6775 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 1549 1549
Lines 62409 62409
Branches 2125 2125
=======================================
Hits 55237 55237
Misses 6845 6845
Partials 327 327
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Thanks! |
What do these changes do?
The Open button in the Study Options view now depends on the title and selected wallet: if both are not set it will be disabled.
Sometimes the e2e would fail because playwright was opening the Study before the title was set.
Related issue/s
How to test
Dev-ops checklist