Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [e2e] Study Options: Open button #6775

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 20, 2024

What do these changes do?

The Open button in the Study Options view now depends on the title and selected wallet: if both are not set it will be disabled.

Sometimes the e2e would fail because playwright was opening the Study before the title was set.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 20, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 20, 2024
@odeimaiz odeimaiz added e2e Bugs found by or related to the end-2-end testing bug buggy, it does not work as expected labels Nov 20, 2024
@odeimaiz odeimaiz changed the title 🐛 [e2e] Wait until a name is suggested before starting a study 🐛 [e2e] Study Options -> Open button Nov 20, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 20, 2024 12:41
@odeimaiz odeimaiz changed the title 🐛 [e2e] Study Options -> Open button 🐛 [e2e] Study Options: Open button Nov 20, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) November 20, 2024 12:41
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (f76be28) to head (9009a38).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6775   +/-   ##
=======================================
  Coverage   88.50%   88.50%           
=======================================
  Files        1549     1549           
  Lines       62409    62409           
  Branches     2125     2125           
=======================================
  Hits        55237    55237           
  Misses       6845     6845           
  Partials      327      327           
Flag Coverage Δ *Carryforward flag
integrationtests 64.85% <ø> (+<0.01%) ⬆️
unittests 86.44% <ø> (ø) Carriedforward from f76be28

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 91.93% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.33% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.54% <ø> (ø)
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 96.98% <ø> (ø)
api_server 89.88% <ø> (ø)
autoscaling 95.22% <ø> (ø)
catalog 89.42% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 75.99% <ø> (ø)
director_v2 90.91% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.01% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 92.87% <ø> (ø)
resource_usage_tracker 90.80% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.74% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76be28...9009a38. Read the comment docs.

---- 🚨 Try these New Features:

@matusdrobuliak66
Copy link
Contributor

Thanks!

@odeimaiz odeimaiz merged commit dce6a40 into ITISFoundation:master Nov 20, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants