Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix agent tests and typecheck #6772

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 20, 2024

What do these changes do?

Fix agent service tests after migration to Pydantic v2.

Related issue/s

How to test

cd services/agent
make pytest

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Nov 20, 2024
@giancarloromeo giancarloromeo added the a:agent agent service label Nov 20, 2024
@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (a0b8a2f) to head (b357b88).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6772      +/-   ##
===============================================================================
+ Coverage                                        85.83%   86.55%   +0.72%     
===============================================================================
  Files                                             1494     1211     -283     
  Lines                                            60526    51621    -8905     
  Branches                                          2010      885    -1125     
===============================================================================
- Hits                                             51950    44680    -7270     
+ Misses                                            8257     6806    -1451     
+ Partials                                           319      135     -184     
Flag Coverage Δ
integrationtests 67.87% <ø> (+3.09%) ⬆️
unittests 84.04% <ø> (+0.35%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.23% <ø> (-0.01%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.36% <ø> (ø)
agent 97.00% <ø> (∅)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.07% <ø> (+0.08%) ⬆️
director_v2 91.13% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server 85.49% <ø> (ø)
payments 92.76% <ø> (ø)
resource_usage_tracker ∅ <ø> (∅)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.51% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b8a2f...b357b88. Read the comment docs.

---- 🚨 Try these New Features:

@giancarloromeo giancarloromeo marked this pull request as ready for review November 20, 2024 09:33
@giancarloromeo giancarloromeo enabled auto-merge (squash) November 20, 2024 09:33
@giancarloromeo giancarloromeo changed the title ♻️ Fix agent tests ♻️ Fix agent tests and typecheck Nov 20, 2024
@giancarloromeo giancarloromeo merged commit 66a492f into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 20, 2024
70 of 75 checks passed
@giancarloromeo giancarloromeo deleted the is4481/fix-agent-tests branch November 21, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:agent agent service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants