Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Director-v0: add setting to control concurrency in client to docker registry #6768

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 19, 2024

What do these changes do?

The PR introduces 2 settings that may be tweaked to test if the DV0 now is a bit too aggressive with our docker registry

Also the concurrency in each replica was reduced from 50 concurrent calls to 20. And the number of objects returned from 50 to 30.

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added a:director issue related with the director service t:maintenance Some planned maintenance work labels Nov 19, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 19, 2024
@sanderegg sanderegg self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.36%. Comparing base (c41b681) to head (fd23011).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c41b681) and HEAD (fd23011). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (c41b681) HEAD (fd23011)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6768       +/-   ##
===========================================
- Coverage   88.51%   65.36%   -23.15%     
===========================================
  Files        1549      633      -916     
  Lines       62410    32221    -30189     
  Branches     2125      265     -1860     
===========================================
- Hits        55240    21062    -34178     
- Misses       6843    11098     +4255     
+ Partials      327       61      -266     
Flag Coverage Δ *Carryforward flag
integrationtests 64.95% <ø> (ø) Carriedforward from c41b681
unittests 76.07% <100.00%> (-10.38%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 76.07% <100.00%> (+0.06%) ⬆️
director_v2 76.74% <ø> (-14.15%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.82% <ø> (-29.93%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.77% <ø> (-28.99%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c41b681...fd23011. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodluck and godspeed (but not too much concurrency ;)

🚀

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci 👍

@sanderegg sanderegg force-pushed the directorv0-add-concurrency-settings branch from 1239d66 to fd23011 Compare November 19, 2024 15:44
@sanderegg sanderegg merged commit 837cddf into ITISFoundation:master Nov 19, 2024
82 of 89 checks passed
@sanderegg sanderegg deleted the directorv0-add-concurrency-settings branch November 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director issue related with the director service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants