-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Director-v0: add setting to control concurrency in client to docker registry #6768
♻️Director-v0: add setting to control concurrency in client to docker registry #6768
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6768 +/- ##
===========================================
- Coverage 88.51% 65.36% -23.15%
===========================================
Files 1549 633 -916
Lines 62410 32221 -30189
Branches 2125 265 -1860
===========================================
- Hits 55240 21062 -34178
- Misses 6843 11098 +4255
+ Partials 327 61 -266
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goodluck and godspeed (but not too much concurrency ;)
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merci 👍
1239d66
to
fd23011
Compare
Quality Gate passedIssues Measures |
What do these changes do?
The PR introduces 2 settings that may be tweaked to test if the DV0 now is a bit too aggressive with our docker registry
Also the concurrency in each replica was reduced from 50 concurrent calls to 20. And the number of objects returned from 50 to 30.
Related issue/s
How to test
Dev-ops checklist