-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️ ♻️ improving e2e tests (adding structure for additional CI tests) #6765
⚗️ ♻️ improving e2e tests (adding structure for additional CI tests) #6765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6765 +/- ##
==========================================
+ Coverage 88.11% 88.53% +0.42%
==========================================
Files 1512 1542 +30
Lines 60601 62208 +1607
Branches 2125 2125
==========================================
+ Hits 53398 55078 +1680
+ Misses 6875 6802 -73
Partials 328 328
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Nice initiative! 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with the idea, but here are a few suggestions to consider:
-
API Calls for Configuration Checks: Instead of testing configurations through the front-end, you might want to use straightforward API calls like
/config
,/statics.json
,/status
, or/diagnostics
. These endpoints typically provide metadata and deployment state information directly. -
Dynamic Badge API: Consider adding an API endpoint to generate a dynamic badge, as demonstrated here. This could be used to create a Markdown table with badges, effectively serving as a dashboard for all deployments.
-
Use Docker Volume Mounts: I’d suggest relying on Docker volume mounts from existing deployments rather than maintaining SQL scripts to inject data. We’ve tried the SQL script approach in the past (some of which may still be in the repo), but the maintenance overhead became significant, especially with frequent database schema changes.
Quality Gate passedIssues Measures |
What do these changes do?
make install-ci-up-simcore
. This command:make test-sleepers
test-platform
.osparc-testing-id
will be added on the new UI elements (folders and workspaces) -> UPDATE: tests modified based on these IDs 🎨 [e2e][Frontend] Folders and Workspaces related test-ids #6766Disclaimer: This is just an experiment. If we find that it is not useful, we do not need to continue. However, I would like to give it a try.
Related issue/s
How to test
Dev-ops checklist