Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All errors in dynamic-sidecar inherit from OsparcErrorMixin #6764

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 19, 2024

What do these changes do?

Refactored errors in dynamic-sidecar thy all inherit from OsparcErrorMixin.
Makes all pylint checks pass.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 19, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 19, 2024
@GitHK GitHK changed the title Pr osparc refeactor erros in dy sidecar2 All errors in dynamic-sidecar inherit from OsparcErrorMixin Nov 19, 2024
@GitHK GitHK marked this pull request as ready for review November 19, 2024 12:11
…quash_updates' into pr-osparc-refeactor-erros-in-dy-sidecar2
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.77%. Comparing base (dcdc863) to head (24f8abd).
Report is 4 commits behind head on pydantic_v2_migration_do_not_squash_updates.

❗ There is a different number of reports uploaded between BASE (dcdc863) and HEAD (24f8abd). Click for more details.

HEAD has 53 uploads less than BASE
Flag BASE (dcdc863) HEAD (24f8abd)
unittests 54 1
Additional details and impacted files
@@                               Coverage Diff                                @@
##           pydantic_v2_migration_do_not_squash_updates    #6764       +/-   ##
================================================================================
- Coverage                                        84.85%   67.77%   -17.08%     
================================================================================
  Files                                             1382      615      -767     
  Lines                                            56116    30896    -25220     
  Branches                                          1296      263     -1033     
================================================================================
- Hits                                             47616    20940    -26676     
- Misses                                            8308     9896     +1588     
+ Partials                                           192       60      -132     
Flag Coverage Δ *Carryforward flag
integrationtests 64.69% <ø> (-0.01%) ⬇️ Carriedforward from 8387d84
unittests 88.80% <100.00%> (+4.37%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.36% <ø> (-8.00%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.25% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.75% <100.00%> (-0.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.79% <ø> (-5.70%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.52% <ø> (-21.00%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcdc863...24f8abd. Read the comment docs.

---- 🚨 Try these New Features:

@GitHK GitHK merged commit a0b8a2f into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 20, 2024
83 of 90 checks passed
@GitHK GitHK deleted the pr-osparc-refeactor-erros-in-dy-sidecar2 branch November 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants