-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All errors in dynamic-sidecar inherit from OsparcErrorMixin
#6764
All errors in dynamic-sidecar inherit from OsparcErrorMixin
#6764
Conversation
OsparcErrorMixin
…quash_updates' into pr-osparc-refeactor-erros-in-dy-sidecar2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6764 +/- ##
================================================================================
- Coverage 84.85% 67.77% -17.08%
================================================================================
Files 1382 615 -767
Lines 56116 30896 -25220
Branches 1296 263 -1033
================================================================================
- Hits 47616 20940 -26676
- Misses 8308 9896 +1588
+ Partials 192 60 -132
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/settings.py
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
a0b8a2f
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
What do these changes do?
Refactored errors in dynamic-sidecar thy all inherit from
OsparcErrorMixin
.Makes all pylint checks pass.
Related issue/s
How to test
Dev-ops checklist