Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Ensure profiling middleware is compatible with fastapi #6760

Conversation

bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Nov 19, 2024

What do these changes do?

  • Fixes
    image

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Nov 19, 2024
@bisgaard-itis bisgaard-itis added the t:enhancement Improvement or request on an existing feature label Nov 19, 2024
@bisgaard-itis bisgaard-itis added this to the Event Horizon milestone Nov 19, 2024
@bisgaard-itis bisgaard-itis changed the base branch from master to pydantic_v2_migration_do_not_squash_updates November 19, 2024 10:08
@bisgaard-itis bisgaard-itis marked this pull request as ready for review November 19, 2024 10:08
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. ok thought that was more than types. thanks!!

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.38%. Comparing base (f442e63) to head (4d90ac5).
Report is 3 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6760      +/-   ##
===============================================================================
+ Coverage                                        84.31%   84.38%   +0.07%     
===============================================================================
  Files                                             1098     1070      -28     
  Lines                                            44466    47395    +2929     
  Branches                                           869      263     -606     
===============================================================================
+ Hits                                             37491    39996    +2505     
- Misses                                            6853     7339     +486     
+ Partials                                           122       60      -62     
Flag Coverage Δ
integrationtests 64.71% <ø> (+6.66%) ⬆️
unittests 83.79% <ø> (+0.04%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.37% <ø> (+19.67%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 76.07% <ø> (+0.08%) ⬆️
director_v2 76.24% <ø> (∅)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.76% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (+45.33%) ⬆️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.51% <ø> (+0.38%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f442e63...4d90ac5. Read the comment docs.

---- 🚨 Try these New Features:

@bisgaard-itis bisgaard-itis merged commit dcdc863 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
83 of 90 checks passed
@bisgaard-itis bisgaard-itis deleted the profiling-middleware-fastapi-compatibility branch November 19, 2024 12:05
@bisgaard-itis bisgaard-itis restored the profiling-middleware-fastapi-compatibility branch November 20, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants