Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️♻️ Fix/test models #6758

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 19, 2024

What do these changes do?

Fixes models-library test_rest_ordering.
Will follow up in a separate PR with the changes in api/specs/web-server

Related issue/s

How to test

Dev-ops checklist

@pcrespov pcrespov self-assigned this Nov 19, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 19, 2024
@pcrespov pcrespov marked this pull request as ready for review November 19, 2024 09:49
@pcrespov pcrespov enabled auto-merge (squash) November 19, 2024 09:50
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pcrespov pcrespov merged commit c10d7d0 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
33 of 38 checks passed
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.68%. Comparing base (f442e63) to head (b482877).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6758      +/-   ##
===============================================================================
+ Coverage                                        84.31%   84.68%   +0.36%     
===============================================================================
  Files                                             1098     1117      +19     
  Lines                                            44466    45801    +1335     
  Branches                                           869      885      +16     
===============================================================================
+ Hits                                             37491    38785    +1294     
- Misses                                            6853     6894      +41     
  Partials                                           122      122              
Flag Coverage Δ *Carryforward flag
integrationtests 58.04% <ø> (ø) Carriedforward from f442e63
unittests 84.14% <100.00%> (+0.38%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.10% <100.00%> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 65.70% <ø> (ø)
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.17% <ø> (ø)
director 75.99% <ø> (ø)
director_v2 ∅ <ø> (∅)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (+0.03%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 40.15% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.79% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.12% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f442e63...b482877. Read the comment docs.

---- 🚨 Try these New Features:

@pcrespov pcrespov deleted the fix/test-models branch November 19, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants