Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Pydantic V2 Update master xxx #6754

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 19, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Nov 19, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 19, 2024
@sanderegg sanderegg self-assigned this Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 84.96732% with 23 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (75f06e4) to head (bcf3327).
Report is 10 commits behind head on pydantic_v2_migration_do_not_squash_updates.

❗ There is a different number of reports uploaded between BASE (75f06e4) and HEAD (bcf3327). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (75f06e4) HEAD (bcf3327)
unittests 30 1
Additional details and impacted files
@@                               Coverage Diff                                @@
##           pydantic_v2_migration_do_not_squash_updates    #6754       +/-   ##
================================================================================
- Coverage                                        87.56%   64.94%   -22.63%     
================================================================================
  Files                                             1534      622      -912     
  Lines                                            61977    31239    -30738     
  Branches                                          2058      265     -1793     
================================================================================
- Hits                                             54268    20287    -33981     
- Misses                                            7390    10891     +3501     
+ Partials                                           319       61      -258     
Flag Coverage Δ *Carryforward flag
integrationtests 64.84% <84.96%> (+0.13%) ⬆️ Carriedforward from 8d03d2a
unittests 79.60% <ø> (-5.88%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.94%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.36% <95.45%> (-14.35%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.76% <ø> (-30.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.81%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.73% <83.20%> (-28.94%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f06e4...bcf3327. Read the comment docs.

---- 🚨 Try these New Features:

@sanderegg sanderegg merged commit 373c314 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 19, 2024
37 of 75 checks passed
@sanderegg sanderegg deleted the update-master-XXX branch November 19, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants