Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️✅ Fixes settings tests #6753

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 18, 2024

What do these changes do?

Addresses failures in autoscaling/tests/unit/test_core_settings.py pointed out by @GitHK

Related issue/s

How to test

cd services/autoscaling
make install-dev
pytest -vv tests/unit/test_core_settings.py

Dev-ops

NOne

@pcrespov pcrespov self-assigned this Nov 18, 2024
@pcrespov pcrespov added the a:autoscaling autoscaling service in simcore's stack label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (44f85bf) to head (db7f4fc).
Report is 2 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6753      +/-   ##
===============================================================================
+ Coverage                                        81.13%   88.53%   +7.39%     
===============================================================================
  Files                                             1530     1268     -262     
  Lines                                            63824    53932    -9892     
  Branches                                          2226      933    -1293     
===============================================================================
- Hits                                             51781    47746    -4035     
+ Misses                                           11708     6051    -5657     
+ Partials                                           335      135     -200     
Flag Coverage Δ
integrationtests 64.73% <ø> (+11.41%) ⬆️
unittests 86.15% <ø> (+1.05%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.18% <ø> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.37% <ø> (+7.10%) ⬆️
agent 97.01% <ø> (ø)
api_server 89.72% <ø> (ø)
autoscaling 95.21% <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 91.26% <ø> (+0.39%) ⬆️
datcore_adapter 93.17% <ø> (ø)
director 58.43% <ø> (ø)
director_v2 90.72% <ø> (+14.52%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.79% <ø> (+30.00%) ⬆️
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.49% <ø> (-0.26%) ⬇️
payments 92.77% <ø> (ø)
resource_usage_tracker 90.64% <ø> (ø)
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.67% <ø> (+8.61%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f85bf...db7f4fc. Read the comment docs.

---- 🚨 Try these New Features:

@pcrespov pcrespov added this to the Event Horizon milestone Nov 18, 2024
@pcrespov pcrespov changed the title WIP: Is4481/fix settings tests ⬆️✅ Fixes settings tests Nov 18, 2024
@pcrespov pcrespov marked this pull request as ready for review November 18, 2024 16:55
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank you!

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pcrespov pcrespov merged commit a6802c9 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 18, 2024
83 of 90 checks passed
@pcrespov pcrespov deleted the is4481/fix-settings-tests branch November 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:autoscaling autoscaling service in simcore's stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants