Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixed broken frontend APIs #6750

Closed
wants to merge 63 commits into from

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 18, 2024

What do these changes do?

API's used in opening a project and adding a new node now respect the OpenAPI spec.

Related issue/s

How to test

Dev-ops checklist

giancarloromeo and others added 30 commits September 18, 2024 11:45
⬆️Update from upstream (must be merged-commited)
sanderegg and others added 24 commits November 1, 2024 12:07
…ter-10

⬆️Update from upstream/master
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Andrei Neagu <[email protected]>
Co-authored-by: Sylvain <[email protected]>
…ter-XXX

⬆️PydanticV2: Update from master
@GitHK GitHK self-assigned this Nov 18, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 18, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 18, 2024
@GitHK GitHK closed this Nov 18, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 86.57331% with 163 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (c83d60c) to head (21c4c0d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6750      +/-   ##
==========================================
- Coverage   87.41%   85.86%   -1.55%     
==========================================
  Files        1570     1539      -31     
  Lines       63322    60748    -2574     
  Branches     2119     2180      +61     
==========================================
- Hits        55351    52160    -3191     
- Misses       7644     8248     +604     
- Partials      327      340      +13     
Flag Coverage Δ
integrationtests 64.73% <ø> (+11.31%) ⬆️
unittests 83.64% <86.57%> (-2.08%) ⬇️
Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library 93.32% <80.43%> (-0.07%) ⬇️
pkg_dask_task_models_library 96.61% <100.00%> (-0.27%) ⬇️
pkg_models_library 91.18% <90.42%> (-0.84%) ⬇️
pkg_notifications_library 84.57% <0.00%> (+0.78%) ⬆️
pkg_postgres_database 87.31% <100.00%> (-0.03%) ⬇️
pkg_service_integration 70.00% <98.24%> (-1.44%) ⬇️
pkg_service_library 76.33% <ø> (-0.18%) ⬇️
pkg_settings_library 91.12% <ø> (-0.30%) ⬇️
pkg_simcore_sdk 85.37% <ø> (+0.10%) ⬆️
agent 97.01% <ø> (+0.02%) ⬆️
api_server 89.72% <ø> (-0.16%) ⬇️
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (+1.14%) ⬆️
clusters_keeper 98.73% <ø> (+<0.01%) ⬆️
dask_sidecar 91.26% <ø> (-0.06%) ⬇️
datcore_adapter 93.17% <ø> (-0.88%) ⬇️
director 58.38% <ø> (ø)
director_v2 90.72% <ø> (-0.19%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.76% <ø> (-0.03%) ⬇️
efs_guardian 90.12% <ø> (+0.10%) ⬆️
invitations 93.49% <ø> (-0.03%) ⬇️
osparc_gateway_server 85.49% <ø> (+0.33%) ⬆️
payments 92.77% <ø> (-0.11%) ⬇️
resource_usage_tracker 90.79% <ø> (-0.01%) ⬇️
storage 89.66% <ø> (-0.11%) ⬇️
webclient ∅ <ø> (∅)
webserver 84.09% <ø> (-3.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83d60c...21c4c0d. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants