Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 adding asyncpg to director-v2 #6746

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 18, 2024

What do these changes do?

  • 🎨 adding asyncpg to director-v2
  • Example:
from ...modules.db import get_asyncpg_engine

asyncpg_engine = get_asyncpg_engine(app)
repo = TagsRepo(asyncpg_engine)
project_tags = await repo.list_tag_ids_and_names_by_project_uuid(
    project_uuid=project.uuid
)

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 added t:maintenance Some planned maintenance work a:director-v2 issue related with the director-v2 service labels Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 18, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 18, 2024 12:30
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!
how many clients does the guy use?

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (c83d60c) to head (312db8c).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c83d60c) and HEAD (312db8c). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (c83d60c) HEAD (312db8c)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6746       +/-   ##
===========================================
- Coverage   87.41%   56.79%   -30.62%     
===========================================
  Files        1570      614      -956     
  Lines       63322    31118    -32204     
  Branches     2119      265     -1854     
===========================================
- Hits        55351    17674    -37677     
- Misses       7644    13383     +5739     
+ Partials      327       61      -266     
Flag Coverage Δ *Carryforward flag
integrationtests 53.41% <ø> (ø) Carriedforward from c83d60c
unittests 84.32% <95.45%> (-1.41%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.81% <95.45%> (-0.10%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.82% <ø> (-29.96%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 40.63% <ø> (-46.96%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83d60c...312db8c. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 18, 2024 13:07
@matusdrobuliak66 matusdrobuliak66 merged commit 03cc706 into ITISFoundation:master Nov 18, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants