Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [e2e-playwright] Fix tests, 2nd attempt #6735

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

odeimaiz
Copy link
Member

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 15, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 15, 2024
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Nov 15, 2024
@odeimaiz odeimaiz marked this pull request as draft November 15, 2024 14:59
@odeimaiz odeimaiz changed the title 🐛 [e2e-playwrigght] 2nd attempt 🐛 [e2e-playwrigght] Fix tests, 2nd attempt Nov 15, 2024
@odeimaiz odeimaiz changed the title 🐛 [e2e-playwrigght] Fix tests, 2nd attempt 🐛 [e2e-playwright] Fix tests, 2nd attempt Nov 15, 2024
@odeimaiz odeimaiz marked this pull request as ready for review November 15, 2024 15:02
@odeimaiz odeimaiz enabled auto-merge (squash) November 15, 2024 15:03
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (fd6a436) to head (c507c7a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6735   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files        1570     1570           
  Lines       63326    63326           
  Branches     2119     2119           
=======================================
  Hits        55559    55559           
  Misses       7440     7440           
  Partials      327      327           
Flag Coverage Δ *Carryforward flag
integrationtests 64.84% <ø> (-0.02%) ⬇️
unittests 85.69% <ø> (ø) Carriedforward from fd6a436

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 79.60% <ø> (ø)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 92.01% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.33% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.50% <ø> (ø)
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 96.98% <ø> (ø)
api_server 89.88% <ø> (ø)
autoscaling 95.22% <ø> (ø)
catalog 89.42% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.86% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.01% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 92.87% <ø> (ø)
resource_usage_tracker 90.80% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.71% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd6a436...c507c7a. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question, why you don't run it straight against the deploy for testing?

@odeimaiz
Copy link
Member Author

just one question, why you don't run it straight against the deploy for testing?

Because I would need to upgrade to python 3.11

@odeimaiz odeimaiz merged commit 9915ebd into ITISFoundation:master Nov 15, 2024
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants