♻️Fixed Unit test director v2 #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
pcrespov,
GitHK and
matusdrobuliak66
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6733 +/- ##
================================================================================
+ Coverage 67.96% 82.69% +14.72%
================================================================================
Files 1427 1232 -195
Lines 57729 56359 -1370
Branches 2229 1011 -1218
================================================================================
+ Hits 39238 46604 +7366
+ Misses 18157 9612 -8545
+ Partials 334 143 -191
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
pcrespov
reviewed
Nov 15, 2024
services/director-v2/src/simcore_service_director_v2/models/comp_runs.py
Show resolved
Hide resolved
sanderegg
merged commit 84c4c85
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
the fix for the clusters is ugly, but these will disappear soon.
The issue arise because the ClusterGet is the same as the internal model and the webserver likes to have them frozen (after validators cannot run in frozen models).
since this is pretty much unused I will not waste any more time on this.
Related issue/s
How to test
Dev-ops checklist