Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix listing folders in workspace #6718

Merged

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Nov 13, 2024

What do these changes do?

  • 🐛 Fix listing folders in workspace

Related issue/s

How to test

  • test_listing_folders_and_projects_in_workspace__multiple_workspaces_created

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review November 13, 2024 15:03
@matusdrobuliak66 matusdrobuliak66 self-assigned this Nov 13, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Nov 13, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Nov 13, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merci

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.23%. Comparing base (d5dca96) to head (4007ece).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d5dca96) and HEAD (4007ece). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (d5dca96) HEAD (4007ece)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6718       +/-   ##
===========================================
- Coverage   87.74%   69.23%   -18.52%     
===========================================
  Files        1571      614      -957     
  Lines       63213    31037    -32176     
  Branches     2117      265     -1852     
===========================================
- Hits        55468    21489    -33979     
- Misses       7420     9487     +2067     
+ Partials      325       61      -264     
Flag Coverage Δ *Carryforward flag
integrationtests 64.88% <ø> (ø) Carriedforward from d5dca96
unittests 62.75% <0.00%> (-22.97%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.52% <ø> (-14.36%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.79% <ø> (-30.01%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.68% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 67.06% <0.00%> (-21.67%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5dca96...4007ece. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) November 13, 2024 17:44
@matusdrobuliak66 matusdrobuliak66 merged commit a4b7c7a into ITISFoundation:master Nov 13, 2024
52 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-folder-db-4 branch November 13, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants