Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨🐛 Enh/fix: frontend knows about trashedAt #6717

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 13, 2024

What do these changes do?

The backend is already providing the trashedAt property, while the frontend doesn't yet know how to handle it.

This PR brings some "Trash bin" logic to the frontend to make it compatible with the current frontend.

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 13, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 13, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) November 13, 2024 13:50
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing

@odeimaiz odeimaiz requested a review from sanderegg November 13, 2024 13:54
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Nov 13, 2024
@odeimaiz odeimaiz merged commit d5dca96 into ITISFoundation:master Nov 13, 2024
50 of 51 checks passed
@odeimaiz odeimaiz deleted the enh/trashed-at branch November 13, 2024 14:16
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 13, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants