-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ instrument (opentelemetry) httpx clients #6715
✨ instrument (opentelemetry) httpx clients #6715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6715 +/- ##
===========================================
- Coverage 87.74% 65.31% -22.43%
===========================================
Files 1571 638 -933
Lines 63215 31554 -31661
Branches 2117 265 -1852
===========================================
- Hits 55465 20611 -34854
- Misses 7425 10882 +3457
+ Partials 325 61 -264
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting one.. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks
very nice thanks a lot, all good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good I see no issues, thx!
What do these changes do?
httpx
clients using https://pypi.org/project/opentelemetry-instrumentation-httpx/produces an instrumented client whereas
doesn't. Essentially they are mocking the httpx clients. I prefer passing objects around to using black magic.
Related issue/s
How to test
Dev-ops checklist