Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Computational backend: refactoring of dv-2 computational scheduler (Part 2) #6711

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 12, 2024

What do these changes do?

NOTE: all replicas might still schedule the same pipelines which is inefficient, this will be the subject of PR part 3

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 12, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 12, 2024
@sanderegg sanderegg self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.64%. Comparing base (9915ebd) to head (13af039).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6711      +/-   ##
==========================================
+ Coverage   87.74%   88.64%   +0.90%     
==========================================
  Files        1570     1271     -299     
  Lines       63326    54555    -8771     
  Branches     2119      897    -1222     
==========================================
- Hits        55564    48360    -7204     
+ Misses       7435     6061    -1374     
+ Partials      327      134     -193     
Flag Coverage Δ
integrationtests 64.86% <82.69%> (-0.02%) ⬇️
unittests 86.29% <92.45%> (+0.59%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.01% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 96.98% <ø> (ø)
api_server 89.88% <ø> (ø)
autoscaling 95.22% <ø> (ø)
catalog 89.42% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (-0.05%) ⬇️
director_v2 90.81% <92.30%> (-0.05%) ⬇️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.78% <ø> (ø)
efs_guardian 90.01% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 92.87% <ø> (ø)
resource_usage_tracker 90.65% <ø> (-0.15%) ⬇️
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 88.71% <ø> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9915ebd...13af039. Read the comment docs.

@sanderegg sanderegg force-pushed the computational-backend/release-scheduler-gil2 branch 4 times, most recently from b591a9d to 8d63020 Compare November 14, 2024 16:19
@sanderegg sanderegg marked this pull request as ready for review November 14, 2024 16:24
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. left some comments

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow comments did not make it in my last review ...here they are

@sanderegg sanderegg force-pushed the computational-backend/release-scheduler-gil2 branch from 8d63020 to 13af039 Compare November 15, 2024 15:29
@sanderegg sanderegg merged commit 7ec1d25 into ITISFoundation:master Nov 18, 2024
86 of 89 checks passed
@sanderegg sanderegg deleted the computational-backend/release-scheduler-gil2 branch November 18, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants