-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Computational backend: refactoring of dv-2 computational scheduler (Part 2) #6711
✨Computational backend: refactoring of dv-2 computational scheduler (Part 2) #6711
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6711 +/- ##
==========================================
+ Coverage 87.74% 88.64% +0.90%
==========================================
Files 1570 1271 -299
Lines 63326 54555 -8771
Branches 2119 897 -1222
==========================================
- Hits 55564 48360 -7204
+ Misses 7435 6061 -1374
+ Partials 327 134 -193
Continue to review full report in Codecov by Sentry.
|
b591a9d
to
8d63020
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx. left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow comments did not make it in my last review ...here they are
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_base_scheduler.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_dask_scheduler.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_dask_scheduler.py
Show resolved
Hide resolved
...ces/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_scheduler_factory.py
Show resolved
Hide resolved
8d63020
to
13af039
Compare
Quality Gate passedIssues Measures |
What do these changes do?
This PR removes:
NOTE: all replicas might still schedule the same pipelines which is inefficient, this will be the subject of PR part 3
Related issue/s
How to test
Dev-ops checklist