Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔨 Fix: e2e Performance Tests in CI #6707

Merged
merged 4 commits into from
Nov 12, 2024
Merged

🔨 Fix: e2e Performance Tests in CI #6707

merged 4 commits into from
Nov 12, 2024

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Nov 12, 2024 •
edited
Loading

What do these changes do?

This PR addresses the failure of performance tests to run in the CI environment after an e2e upgrade in Python.

  • Dependency Injection: Adjusted .env generation as make config was producing an empty file. Now, dependencies are injected into locust_settings.py using uv add --script ..., allowing it to run as a standalone script.
  • CLI Argument Fix: Corrected cut command arguments to ensure proper execution
  • Environment Variable Validation: Added initial checks for additional required environment variables.

Related issue/s

  • portal e2e failures since docker:latest updated and installs new version of python

How to test

Dev-ops

None

@pcrespov pcrespov self-assigned this Nov 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pcrespov pcrespov added the e2e Bugs found by or related to the end-2-end testing label Nov 12, 2024
@pcrespov pcrespov changed the title 🔨 Fixes e2e tests/perfomance 🔨 Fixes e2e: tests/perfomance Nov 12, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Nov 12, 2024
@pcrespov pcrespov marked this pull request as ready for review November 12, 2024 09:53
@pcrespov pcrespov requested a review from sanderegg as a code owner November 12, 2024 09:53
@pcrespov pcrespov changed the title 🔨 Fixes e2e: tests/perfomance 🔨 Fix: e2e Performance Tests in CI Nov 12, 2024
@pcrespov pcrespov merged commit ec1e84e into ITISFoundation:master Nov 12, 2024
36 of 37 checks passed
@pcrespov pcrespov deleted the mai/e2e-performance branch November 12, 2024 09:58
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 26, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@pcrespov pcrespov

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
1 participant
@pcrespov