Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydantic2 making ported services green #6701

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 11, 2024

What do these changes do?

  • ⬆️ upgraded osparc-gateway-server to pedantic2
  • made all unit tests in upgraded services (except director-v2) compatible green
  • tests inside autoscaling and clusters-keeper that fails due to errors with the settings have been disabled

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Nov 11, 2024
@GitHK GitHK added this to the Event Horizon milestone Nov 11, 2024
@GitHK GitHK added the t:maintenance Some planned maintenance work label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.06%. Comparing base (f07afbf) to head (b90220c).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

❗ There is a different number of reports uploaded between BASE (f07afbf) and HEAD (b90220c). Click for more details.

HEAD has 16 uploads less than BASE
Flag BASE (f07afbf) HEAD (b90220c)
unittests 17 1
Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6701      +/-   ##
===============================================================================
- Coverage                                        74.54%   65.06%   -9.49%     
===============================================================================
  Files                                             1182      614     -568     
  Lines                                            47147    29988   -17159     
  Branches                                          1495      349    -1146     
===============================================================================
- Hits                                             35146    19511   -15635     
+ Misses                                           11793    10404    -1389     
+ Partials                                           208       73     -135     
Flag Coverage Δ *Carryforward flag
integrationtests 65.07% <ø> (-0.03%) ⬇️ Carriedforward from bded988
unittests 64.05% <50.00%> (-20.36%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (-0.85%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.18% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.80% <ø> (-29.54%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.41% <ø> (-0.11%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.92% <ø> (-0.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07afbf...b90220c. Read the comment docs.

@GitHK GitHK changed the title Pr osparc py2 grinify unit test2 pydantic2 making ported services green Nov 11, 2024
@GitHK GitHK marked this pull request as ready for review November 11, 2024 12:43
@GitHK GitHK requested a review from giancarloromeo November 11, 2024 12:43
@GitHK GitHK requested review from sanderegg and pcrespov November 12, 2024 14:15
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some last comments.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@GitHK GitHK merged commit a00d55f into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 13, 2024
68 of 90 checks passed
@GitHK GitHK deleted the pr-osparc-py2-grinify-unit-test2 branch November 13, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants