Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨🐛 [Frontend] Reduce the initial number of patch calls #6641

Merged
merged 15 commits into from
Nov 1, 2024
Merged

🎨🐛 [Frontend] Reduce the initial number of patch calls #6641

merged 15 commits into from
Nov 1, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 30, 2024 •
edited
Loading

What do these changes do?

  • reduce the initial patch calls (there was a bug in the initial Folder ID, Workspace ID and description values)

Bonus

  • reduce the calls for presigned link
  • Fix: Open Study location context
  • Fix: STATE_VOLUMES -> STATES_VOLUMES

Before (3+2 Patch calls):
Before

After (2 Patch calls):
After

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 30, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Oct 30, 2024
@odeimaiz odeimaiz added this to the Caveman milestone Oct 30, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 30, 2024 17:48
@odeimaiz odeimaiz enabled auto-merge (squash) October 30, 2024 17:48
@odeimaiz odeimaiz changed the title 🎨🐛 [Frontend] Reduce the number of patch calls 🎨🐛 [Frontend] Reduce the initial number of patch calls Oct 30, 2024
pcrespov
pcrespov reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

sanderegg
sanderegg approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mrnicegyu11 mrnicegyu11 disabled auto-merge November 1, 2024 09:46
@mrnicegyu11 mrnicegyu11 merged commit cdbaf0c into ITISFoundation:master Nov 1, 2024
49 of 50 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@odeimaiz @GitHK @pcrespov @sanderegg @matusdrobuliak66 @mrnicegyu11