-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ upgrades iter_model_examples_in_module
to enable all example tests
#6632
⬆️ upgrades iter_model_examples_in_module
to enable all example tests
#6632
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot 🙏🏻
afa0b3c
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. no need to force merge, it is mergeable as is ;)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6632 +/- ##
===============================================================================
- Coverage 71.32% 70.62% -0.71%
===============================================================================
Files 1070 1022 -48
Lines 48181 46656 -1525
Branches 1243 1243
===============================================================================
- Hits 34365 32949 -1416
+ Misses 13593 13486 -107
+ Partials 223 221 -2
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
What do these changes do?
This PR resolves the issue where tests validating examples were previously skipped due to an incomplete upgrade of
iter_model_examples_in_module
.NOte that most likely your tests on examples will fail due to the following: Pydantic 2 behavior, which now enforces that fields cannot have
None
as a default unless explicitly declared as nullable (i.e.,field: Type | None
). This update ensures compatibility with these stricter type requirements.NOTE: when approved, I will force-merge into the branch so we can review the example tests separately.
Related issue/s
How to test
Dev-ops checklist