Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️Pydantic V2 update from master #6626

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 29, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Oct 29, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 29, 2024
@sanderegg sanderegg self-assigned this Oct 29, 2024
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 62.74510% with 19 lines in your changes missing coverage. Please review.

Project coverage is 63.36%. Comparing base (06df37d) to head (7033151).
Report is 19 commits behind head on pydantic_v2_migration_do_not_squash_updates.

❗ There is a different number of reports uploaded between BASE (06df37d) and HEAD (7033151). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (06df37d) HEAD (7033151)
unittests 29 1
Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6626      +/-   ##
===============================================================================
- Coverage                                        71.32%   63.36%   -7.97%     
===============================================================================
  Files                                             1070      649     -421     
  Lines                                            48181    32778   -15403     
  Branches                                          1243      265     -978     
===============================================================================
- Hits                                             34365    20769   -13596     
+ Misses                                           13593    11948    -1645     
+ Partials                                           223       61     -162     
Flag Coverage Δ *Carryforward flag
integrationtests 63.69% <62.74%> (-1.05%) ⬇️ Carriedforward from f870beb
unittests 58.43% <ø> (-23.45%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (ø)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director 58.43% <ø> (ø)
director_v2 76.27% <ø> (+0.06%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.66% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.99%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 57.82% <62.74%> (-1.79%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06df37d...7033151. Read the comment docs.

@sanderegg sanderegg merged commit 4fd252f into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 29, 2024
@sanderegg sanderegg deleted the upgrade-master-3 branch October 29, 2024 08:19
Copy link

@sanderegg sanderegg modified the milestones: MartinKippenberger, Caveman Oct 29, 2024
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants