-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrade Director v2 service (Pydantic v2) #6619
⬆️ Upgrade Director v2 service (Pydantic v2) #6619
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pydantic_v2_migration_do_not_squash_updates #6619 +/- ##
================================================================================
- Coverage 85.52% 64.44% -21.08%
================================================================================
Files 1560 648 -912
Lines 63404 31599 -31805
Branches 2207 316 -1891
================================================================================
- Hits 54227 20365 -33862
- Misses 8844 11174 +2330
+ Partials 333 60 -273
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
…1/upgrade-director-v2-service
…1/upgrade-director-v2-service
…arloromeo/osparc-simcore into is4481/upgrade-director-v2-service
…1/upgrade-director-v2-service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me this can be merged as soon a director-v2 tests are green
Quality Gate failedFailed conditions |
@sanderegg, thank you for taking care after merge: |
f335bca
into
ITISFoundation:pydantic_v2_migration_do_not_squash_updates
What do these changes do?
Upgrade Director-v2 service to Pydantic v2.
Related issue/s
How to test
Dev-ops checklist