Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 [Frontend] Publish template UI/UX #6617

Merged
merged 15 commits into from
Oct 29, 2024
Merged

🎨 [Frontend] Publish template UI/UX #6617

merged 15 commits into from
Oct 29, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 28, 2024 •
edited
Loading

What do these changes do?

  • Move the "Check organization" button to the right, so it is less distracting
  • Rename the button to "My organizations"
  • "Share with" might be confusing, because in this view we're publishing a template. Change it to "Publish for..."

PublishTemplate

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 28, 2024
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature labels Oct 28, 2024
@odeimaiz odeimaiz marked this pull request as ready for review October 28, 2024 14:18
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 28, 2024
@odeimaiz odeimaiz enabled auto-merge (squash) October 28, 2024 14:19
GitHK
GitHK reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pcrespov
pcrespov reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to merge "share" and "publish" into a single concept? AFAIK the latter is basically sharing a study as a template. E.g. would be "Share with ... " and/or "Share as template with ... "

@odeimaiz
Copy link
Member Author

Would it make sense to merge "share" and "publish" into a single concept? AFAIK the latter is basically sharing a study as a template. E.g. would be "Share with ... " and/or "Share as template with ... "

That's exactly what we are running away from.

sanderegg
sanderegg reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@odeimaiz odeimaiz modified the milestones: MartinKippenberger, Caveman Oct 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit 6db71c1 into ITISFoundation:master Oct 29, 2024
49 of 50 checks passed
This was referenced Oct 30, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@GitHK GitHK GitHK left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Publish templates UI/sharing widget improvements
6 participants
@odeimaiz @jsaq007 @GitHK @pcrespov @sanderegg @matusdrobuliak66