Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Reduce noisyness of gunicorn and socketio in webserver logs #6616

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 28, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Oct 28, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 28, 2024
@sanderegg sanderegg self-assigned this Oct 28, 2024
@sanderegg sanderegg requested a review from YuryHrytsuk October 28, 2024 13:52
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Thx

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.11%. Comparing base (be8e3e9) to head (991a2a2).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6616      +/-   ##
==========================================
+ Coverage   73.70%   78.11%   +4.41%     
==========================================
  Files        1247      606     -641     
  Lines       52093    30692   -21401     
  Branches     1187      265     -922     
==========================================
- Hits        38393    23976   -14417     
+ Misses      13530     6655    -6875     
+ Partials      170       61     -109     
Flag Coverage Δ *Carryforward flag
integrationtests 63.69% <ø> (ø) Carriedforward from be8e3e9
unittests 80.98% <ø> (-3.99%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.27% <ø> (ø)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.66% <ø> (ø)
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 82.09% <ø> (+24.26%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8e3e9...991a2a2. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline. After this commit, it would be desirable to do changes on loggers using config https://docs.python.org/3/library/logging.config.html

@sanderegg sanderegg force-pushed the reduce-noisy-loggers-webserver branch from 718a1aa to 991a2a2 Compare October 28, 2024 14:41
@sanderegg sanderegg merged commit 59f0725 into ITISFoundation:master Oct 28, 2024
@sanderegg sanderegg deleted the reduce-noisy-loggers-webserver branch October 28, 2024 14:41
Copy link

@sanderegg sanderegg modified the milestones: MartinKippenberger, Caveman Oct 29, 2024
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants