Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 removes unsupported parameter #6612

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 28, 2024

What do these changes do?

Removed parameter which is no longer accepted by the function, even though the documentation states otherwise. During runtime an error is raised which pollutes the logs.

Related issue/s

How to test

Dev-ops checklist

@GitHK GitHK self-assigned this Oct 28, 2024
@GitHK GitHK marked this pull request as ready for review October 28, 2024 11:45
@GitHK GitHK requested a review from pcrespov as a code owner October 28, 2024 11:45
@GitHK GitHK changed the title 🐛 remove unsupported parameter 🐛 removes unsupported parameter Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (50076aa) to head (6654195).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6612      +/-   ##
==========================================
- Coverage   87.83%   87.69%   -0.15%     
==========================================
  Files        1561     1170     -391     
  Lines       62760    51451   -11309     
  Branches     2085      958    -1127     
==========================================
- Hits        55127    45120   -10007     
+ Misses       7315     6154    -1161     
+ Partials      318      177     -141     
Flag Coverage Δ *Carryforward flag
integrationtests 64.83% <ø> (+4.05%) ⬆️ Carriedforward from 80f9674
unittests 85.18% <100.00%> (-1.29%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.68% <100.00%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.16% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.26% <ø> (ø)
catalog ∅ <ø> (∅)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 91.30% <ø> (ø)
datcore_adapter 94.02% <ø> (ø)
director 58.38% <ø> (-0.05%) ⬇️
director_v2 90.84% <ø> (+0.11%) ⬆️
dynamic_scheduler 96.62% <ø> (ø)
dynamic_sidecar 89.71% <ø> (ø)
efs_guardian 87.03% <ø> (ø)
invitations 93.47% <ø> (ø)
osparc_gateway_server 85.41% <ø> (+0.26%) ⬆️
payments 93.08% <ø> (ø)
resource_usage_tracker 87.36% <ø> (ø)
storage 89.73% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.30% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50076aa...6654195. Read the comment docs.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pair reviewed

@GitHK GitHK enabled auto-merge (squash) October 29, 2024 07:20
@GitHK GitHK modified the milestones: Caveman, MartinKippenberger Oct 29, 2024
Copy link

@pcrespov pcrespov disabled auto-merge October 29, 2024 14:31
@pcrespov pcrespov merged commit 9e0d75b into ITISFoundation:master Oct 29, 2024
3 checks passed
@GitHK GitHK deleted the pr-osparc-cleanup-untracked-services branch October 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants