Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨Fix codecov4 #6610

Merged
merged 7 commits into from
Oct 28, 2024
Merged

🔨Fix codecov4 #6610

merged 7 commits into from
Oct 28, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 28, 2024

What do these changes do?

  • set the threshold of reduced coverage to 1% to prevent 0.xx changes of coverage
  • fixed path to dask-task-models-library
  • attempt to add the api tests

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg self-assigned this Oct 28, 2024
@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Oct 28, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 28, 2024
@sanderegg sanderegg merged commit 0111cb9 into ITISFoundation:master Oct 28, 2024
2 checks passed
@sanderegg sanderegg deleted the fix-codecov4 branch October 28, 2024 12:44
Copy link

@sanderegg sanderegg added the t:maintenance Some planned maintenance work label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (27ceb6f) to head (497e73f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6610   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files        1552     1552           
  Lines       62361    62361           
  Branches     2085     2085           
=======================================
  Hits        52425    52425           
  Misses       9618     9618           
  Partials      318      318           
Flag Coverage Δ *Carryforward flag
integrationtests 64.77% <ø> (ø) Carriedforward from 27ceb6f
unittests 81.86% <ø> (ø) Carriedforward from 27ceb6f

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.38% <ø> (ø)
pkg_dask_task_models_library 96.87% <ø> (ø)
pkg_models_library 92.13% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.77% <ø> (ø)
pkg_service_integration 71.44% <ø> (ø)
pkg_service_library 76.69% <ø> (ø)
pkg_settings_library 91.42% <ø> (ø)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.16% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.26% <ø> (ø)
catalog 89.51% <ø> (ø)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 91.30% <ø> (ø)
datcore_adapter 94.02% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.75% <ø> (ø)
dynamic_scheduler 96.62% <ø> (ø)
dynamic_sidecar 89.70% <ø> (ø)
efs_guardian 87.03% <ø> (ø)
invitations 93.47% <ø> (ø)
osparc_gateway_server 85.41% <ø> (ø)
payments 93.08% <ø> (ø)
resource_usage_tracker 87.36% <ø> (ø)
storage 89.73% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 76.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ceb6f...497e73f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants