Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Fix settings library tests #6605

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 25, 2024

What do these changes do?

  • moves the json_serialization.py to the common library to make many services happy

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg force-pushed the move-json-serialization branch from 31abdd5 to 3b6ab28 Compare October 25, 2024 13:54
Copy link

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (fb48eb1) to head (3b6ab28).
Report is 4 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6605      +/-   ##
===============================================================================
+ Coverage                                        80.94%   81.47%   +0.53%     
===============================================================================
  Files                                              289      484     +195     
  Lines                                            10605    18152    +7547     
  Branches                                           346     1009     +663     
===============================================================================
+ Hits                                              8584    14790    +6206     
- Misses                                            1975     3188    +1213     
- Partials                                            46      174     +128     
Flag Coverage Δ
unittests 81.47% <100.00%> (+0.53%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library 76.61% <100.00%> (∅)
pkg_settings_library 90.42% <77.77%> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent 97.21% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.25% <100.00%> (∅)
catalog ∅ <ø> (∅)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 90.84% <100.00%> (+0.01%) ⬆️
datcore_adapter 93.14% <ø> (ø)
director 58.21% <ø> (-0.05%) ⬇️
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar ∅ <ø> (∅)
efs_guardian ∅ <ø> (∅)
invitations 93.44% <ø> (ø)
migration ∅ <ø> (∅)
osparc_gateway_server 39.84% <ø> (ø)
payments 92.98% <100.00%> (ø)
resource_usage_tracker ∅ <ø> (∅)
storage 89.63% <91.39%> (∅)
webclient ∅ <ø> (∅)
webserver ∅ <ø> (∅)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39aed6a...3b6ab28. Read the comment docs.

@sanderegg sanderegg merged commit e38cf4e into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 28, 2024
28 of 58 checks passed
@sanderegg sanderegg deleted the move-json-serialization branch October 28, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants