-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Remove PUT project endpoint #6604
♻️ Remove PUT project endpoint #6604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6604 +/- ##
==========================================
+ Coverage 87.87% 88.72% +0.85%
==========================================
Files 1552 1262 -290
Lines 62416 53911 -8505
Branches 2085 885 -1200
==========================================
- Hits 54847 47835 -7012
+ Misses 7251 5942 -1309
+ Partials 318 134 -184
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long live the PUT
services/web/server/src/simcore_service_webserver/projects/_crud_handlers.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_crud_handlers.py
Show resolved
Hide resolved
services/web/server/tests/unit/with_dbs/03/meta_modeling/test_meta_modeling_iterations.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand why we keep it? there is no one else but the frontend using that entrypoint right? why keep it at all?
UPDATE: I have removed the PUT endpoint 👍 |
Quality Gate passedIssues Measures |
27ceb6f
into
ITISFoundation:master
What do these changes do?
Related issue/s
How to test
Dev-ops checklist