Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 FIX: project patch when wallet not shared #6602

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Oct 25, 2024

What do these changes do?

  • 🐛 Removes call to director-v2 which is not needed for patching of project data

Related issue/s

How to test

Dev-ops checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 added the bug buggy, it does not work as expected label Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the MartinKippenberger milestone Oct 25, 2024
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review October 25, 2024 11:16
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Oct 25, 2024
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (dea8991) to head (0e3425d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (dea8991) and HEAD (0e3425d). Click for more details.

HEAD has 26 uploads less than BASE
Flag BASE (dea8991) HEAD (0e3425d)
unittests 29 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6602      +/-   ##
==========================================
- Coverage   87.87%   82.42%   -5.46%     
==========================================
  Files        1552      606     -946     
  Lines       62417    30738   -31679     
  Branches     2085      265    -1820     
==========================================
- Hits        54852    25335   -29517     
+ Misses       7248     5342    -1906     
+ Partials      317       61     -256     
Flag Coverage Δ
integrationtests 64.71% <ø> (-0.03%) ⬇️
unittests 87.92% <ø> (+2.07%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.44% <ø> (-7.84%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 76.20% <ø> (-14.55%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 59.66% <ø> (-30.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
migration ∅ <ø> (∅)
osparc_gateway_server 79.42% <ø> (-5.73%) ⬇️
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 89.34% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea8991...0e3425d. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was it there then?

@matusdrobuliak66
Copy link
Contributor Author

matusdrobuliak66 commented Oct 25, 2024

why was it there then?

When I was introducing PATCH 5 months ago I thought it was needed. Probably because I started from the PUT project and there it was necessary because we were updating the workbench, which is not the case anymore.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) October 25, 2024 13:44
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 7e052f5 into ITISFoundation:master Oct 28, 2024
86 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: patch a project/node requires wallet access
4 participants