Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Use correct import #6597

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 24, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Oct 24, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 24, 2024
@sanderegg sanderegg self-assigned this Oct 24, 2024
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (pydantic_v2_migration_do_not_squash_updates@6199ed6). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##             pydantic_v2_migration_do_not_squash_updates   #6597   +/-   ##
=============================================================================
  Coverage                                               ?   80.1%           
=============================================================================
  Files                                                  ?     405           
  Lines                                                  ?   16013           
  Branches                                               ?     857           
=============================================================================
  Hits                                                   ?   12834           
  Misses                                                 ?    3036           
  Partials                                               ?     143           
Flag Coverage Δ
unittests 80.1% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...library/src/servicelib/aiohttp/rest_middlewares.py 72.0% <100.0%> (ø)
...s/service-library/src/servicelib/logging_errors.py 100.0% <100.0%> (ø)

@sanderegg sanderegg merged commit cd6f545 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 24, 2024
27 of 43 checks passed
@sanderegg sanderegg deleted the remove-duplicated-error-code branch October 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants