Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️Datcore adapter: migration #6594

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 24, 2024

What do these changes do?

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (pydantic_v2_migration_do_not_squash_updates@cd6f545). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...vice_datcore_adapter/api/errors/pennsieve_error.py 0.0% 3 Missing ⚠️
...e_service_datcore_adapter/api/errors/http_error.py 66.6% 1 Missing ⚠️
...ice_datcore_adapter/api/errors/validation_error.py 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##             pydantic_v2_migration_do_not_squash_updates   #6594   +/-   ##
=============================================================================
  Coverage                                               ?   93.1%           
=============================================================================
  Files                                                  ?      24           
  Lines                                                  ?     540           
  Branches                                               ?       0           
=============================================================================
  Hits                                                   ?     503           
  Misses                                                 ?      37           
  Partials                                               ?       0           
Flag Coverage Δ
unittests 93.1% <70.5%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...apter/src/simcore_service_datcore_adapter/_meta.py 100.0% <100.0%> (ø)
...imcore_service_datcore_adapter/api/routes/files.py 100.0% <100.0%> (ø)
...imcore_service_datcore_adapter/core/application.py 97.7% <100.0%> (ø)
...c/simcore_service_datcore_adapter/core/settings.py 100.0% <100.0%> (ø)
...service_datcore_adapter/models/schemas/datasets.py 100.0% <ø> (ø)
...e_service_datcore_adapter/api/errors/http_error.py 50.0% <66.6%> (ø)
...ice_datcore_adapter/api/errors/validation_error.py 83.3% <0.0%> (ø)
...vice_datcore_adapter/api/errors/pennsieve_error.py 50.0% <0.0%> (ø)

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 🚀

@sanderegg sanderegg force-pushed the migration/datcore-adapter branch from b289e6c to a8fd1d1 Compare October 24, 2024 12:28
Copy link

@sanderegg sanderegg merged commit 3cf68ba into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 24, 2024
54 of 58 checks passed
@sanderegg sanderegg deleted the migration/datcore-adapter branch October 24, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants