Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix: Download logs with newlines (Firefox) #6583

Merged
merged 3 commits into from
Oct 23, 2024
Merged

🐛 [Frontend] Fix: Download logs with newlines (Firefox) #6583

merged 3 commits into from
Oct 23, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 23, 2024 •
edited
Loading

What do these changes do?

When Downloading the log file in Firefox wasn't adding any newlines. This PR fixes it.

DownloadLogsFF

Related issue/s

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Oct 23, 2024
@odeimaiz odeimaiz added this to the MartinKippenberger milestone Oct 23, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Oct 23, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz enabled auto-merge (squash) October 23, 2024 11:35
@wvangeit
Copy link
Contributor

Great, thx @odeimaiz !

jsaq007
jsaq007 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@jsaq007 jsaq007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

pcrespov
pcrespov reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@odeimaiz odeimaiz merged commit 5db5ac5 into ITISFoundation:master Oct 23, 2024
51 checks passed
mrnicegyu11 pushed a commit to mrnicegyu11/osparc-simcore that referenced this pull request Oct 24, 2024
@odeimaiz @mrnicegyu11
🐛 [Frontend] Fix: Download logs with newlines (Firefox) (ITISFoundati…
8160031 
…on#6583)
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov left review comments

@wvangeit wvangeit wvangeit approved these changes

@jsaq007 jsaq007 jsaq007 approved these changes

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.

Downloadable log file doesn't have newlines when using Firefox
4 participants
@odeimaiz @wvangeit @jsaq007 @pcrespov